Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Toggle to shutdown the automatic append of Animation tab to all CTypes #2

Closed
wants to merge 1 commit into from

Conversation

jmverges
Copy link
Contributor

What do you think?

@baschte
Copy link
Owner

baschte commented Mar 21, 2019

@jmverges It could be a very nice feature but what would you do if you select that option (removed it from all CTypes) and then you want to add the animation tab to 6 core elements? Overwrite every CType "showitem" property and add it manually? I think that would be very complicated for all integrators and not "fluid", you know? :-D

What do you think? :-)

@baschte
Copy link
Owner

baschte commented Mar 21, 2019

@jmverges
The other way it works is to do the opposite. Remove the tab only on specific CTypes.

Now you can do it in pageTS for "textpic" for example like this:
TCEFORM.tt_content.tx_content_animations_animation.types.textpic.disabled=1 TCEFORM.tt_content.tx_content_animations_duration.types.textpic.disabled=1 TCEFORM.tt_content.tx_content_animations_delay.types.textpic.disabled=1

@jmverges
Copy link
Contributor Author

To complicated for the integrator, thats why by default is added, but for some other use cases could be useful for developers

@baschte
Copy link
Owner

baschte commented Mar 21, 2019

@jmverges why would you remove the animation tab for all CTypes? So what's the usecase for you? When it will needed for you as a developer?

If i don't want the tab on any CType whats the difference between the setting is disabled and if i deinstall the extension complete?

@jmverges
Copy link
Contributor Author

I tend to have my own custom definition for content elements instead of the ones provides by default in ext:frontend extension. I simply prefer to integrate manually the fields in a different tab and show them if the this extension is installed.

@baschte
Copy link
Owner

baschte commented Apr 11, 2019

Hi @jmverges,
the new version 1.2.0 of content_animations is available with some enhancements and the setting to disable the auto append of the Animation tab. Have fun with it and thx for your PR 😁🍻

@baschte baschte closed this Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants