Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.0.0 #1

Merged
merged 5 commits into from
Aug 23, 2016
Merged

Version 2.0.0 #1

merged 5 commits into from
Aug 23, 2016

Conversation

gakimball
Copy link
Contributor

@gakimball gakimball commented Aug 21, 2016

  • FrontRouter class to handle route data
  • API usable inside and outside of Gulp
  • Incremental building
  • Adapter system
    • Generic adapter
    • Angular 1.x adapter
  • Babel workflow (convert to ES5 before publishing)
  • CLI (as separate repository/module)

@gakimball
Copy link
Contributor Author

@soumak77 The Angular route creator (under libraries/angular.js) needs to be updated to match however the new version of the library handles routes, in terms of service naming and such.

@gakimball
Copy link
Contributor Author

@soumak77 Also regarding this comment, if you need a shorter and more generic name, I'd recommend base-router.

@soumak77
Copy link
Contributor

@gakimball I like the renaming. Would you suggest just renaming this repository and releasing v2 as base-router or create a new repository and start fresh with a 1.0? No one else seems to be using this repository yet so we have the option. The template and docs can be updated as necessary.

@soumak77
Copy link
Contributor

soumak77 commented Aug 21, 2016

@gakimball btw, you are welcome to make these changes yourself as a Base Apps org owner, but of course I'm willing to help out as needed. The only requirements I have is that it works with the angular-base-apps gulp build and the angular-base-apps-template brunch build, but any other changes to make it usable outside of the framework are nice to have.

@@ -0,0 +1,10 @@
module.exports = (routes) => {
return `
angular.module('foundation.dynamicRouting').config([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foundation.dynamicRouting can be renamed to dynamicRouting and FoundationStateProvider can be renamed to BaseAppsStateProvider. These changes are available as part of angular-dynamic-routing v1.1

@soumak77 soumak77 merged commit 8905e49 into master Aug 23, 2016
@soumak77
Copy link
Contributor

@gakimball should have checked this before renaming, but base-router is taken in npm. I'll rename to base-apps-router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants