-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0.0 #1
Conversation
@soumak77 The Angular route creator (under |
@soumak77 Also regarding this comment, if you need a shorter and more generic name, I'd recommend |
@gakimball I like the renaming. Would you suggest just renaming this repository and releasing v2 as |
@gakimball btw, you are welcome to make these changes yourself as a Base Apps org owner, but of course I'm willing to help out as needed. The only requirements I have is that it works with the angular-base-apps gulp build and the angular-base-apps-template brunch build, but any other changes to make it usable outside of the framework are nice to have. |
@@ -0,0 +1,10 @@ | |||
module.exports = (routes) => { | |||
return ` | |||
angular.module('foundation.dynamicRouting').config([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foundation.dynamicRouting
can be renamed to dynamicRouting
and FoundationStateProvider
can be renamed to BaseAppsStateProvider
. These changes are available as part of angular-dynamic-routing v1.1
@gakimball should have checked this before renaming, but |
FrontRouter
class to handle route data