Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork foundation Templates #32

Closed
7 tasks done
soumak77 opened this issue Jul 31, 2016 · 32 comments
Closed
7 tasks done

Fork foundation Templates #32

soumak77 opened this issue Jul 31, 2016 · 32 comments
Assignees
Milestone

Comments

@soumak77
Copy link
Contributor

soumak77 commented Jul 31, 2016

  • fork https://github.com/zurb/foundation-apps-template and update to latest version
  • add section to docs for how to use the template
  • migrate to angular-base-apps 2.0 prerelease
  • integrate angular-dynamic-routing
  • integrate base-apps-router
    • once this PR is merged, the dynamic routing build step will be capable of running outside of gulp.
  • integrate angular-icons
@tolyo
Copy link
Contributor

tolyo commented Aug 6, 2016

@soumak77 Do we need the cli? I don't see the point of it. I will get around the template ASAP.

@soumak77
Copy link
Contributor Author

soumak77 commented Aug 6, 2016

@tolyo whatever steps the CLI performs we can just add to the documentation

@soumak77 soumak77 changed the title Fork foundation CLI and Templates Fork foundation Templates Aug 6, 2016
@tolyo
Copy link
Contributor

tolyo commented Aug 10, 2016

@soumak77 We have two npm repoes right now. Please unpublish the unused one.

@soumak77
Copy link
Contributor Author

@tolyo I tried but the command failed. I opened an issue on npm: npm/npm#13632

@tolyo
Copy link
Contributor

tolyo commented Aug 10, 2016

@soumak77 Roger

@soumak77
Copy link
Contributor Author

soumak77 commented Aug 10, 2016

@tolyo what is the reason for replacing gulp with brunch in the template? Is it just a preference thing or is there a technical reason?

To accommodate all developers, we can create the same template with different build tools. I personally would want to have a gulp build when using the template. The gulp build should also be the default template since the framework uses gulp.

Also, the dynamic routing plugin is built with gulp, so I'm not sure if that will have issues running with brunch.

@soumak77
Copy link
Contributor Author

duplicate npm package has been removed

@tolyo
Copy link
Contributor

tolyo commented Aug 10, 2016

@soumak77 Because it takes more code in gulp to set up ES6 based project with NPM for dependency management. I am assuming that most projects nowadays are started with ES6 and without Bower.

@soumak77
Copy link
Contributor Author

@tolyo understood and I like that direction, but I still think a separate gulp template should be created so that users have options. I personally have never heard of brunch, so if I was new to this framework, I wouldn't like having to learn a separate build system on top of the framework itself.

@tolyo
Copy link
Contributor

tolyo commented Aug 10, 2016

@soumak77 This is a sample to try the framework with sensible and modern defaults and not a reference on how the framework should be used. Feel free to replace it with Gulp or Grunt, but the previous version of the template is legacy.

@soumak77
Copy link
Contributor Author

soumak77 commented Aug 10, 2016

@tolyo I agree I'm looking at it from the standpoint of today versus the future. Once #42 has been completed, gulp won't be a hard dependency for the framework, so it won't matter at that point.

@tolyo
Copy link
Contributor

tolyo commented Aug 10, 2016

@soumak77 This isn't close to being done. I want to add sample apps to this: a) a chat app b) a dashboard app and c) task management app

@soumak77
Copy link
Contributor Author

@tolyo looking forward to it! We can use github pages to host the apps like we do with the docs. I integrated https://www.npmjs.com/package/gh-pages into the framework build to auto-publish the docs.

@tolyo
Copy link
Contributor

tolyo commented Aug 11, 2016

@soumak77 I've been looking around for a solid Gulp ES6 stack and they all use Webpack. So it would require an introduction of yet another tool.

@soumak77
Copy link
Contributor Author

@tolyo On an enterprise scale, the build systems can get pretty complex and I would like to have a template that understands this and makes it easy to build scalable apps from the start. At the same time, I don't want too complex of a build that new comers are off put by using the framework just to hack something together.

Not sure if that helps, but that's my thinking. If trying to make the base template requires too much upfront knowledge, we can maybe split the template into basic and enterprise versions.

@tolyo
Copy link
Contributor

tolyo commented Aug 12, 2016

@soumak77 Shooting just for minimal code for now.

@soumak77
Copy link
Contributor Author

@tolyo sounds good. I want to have a template available for the 2.0 release, so let me know when you get it working for 1.x and I can migrate it to 2.x.

@soumak77 soumak77 added this to the 2.0 Release milestone Aug 12, 2016
@tolyo
Copy link
Contributor

tolyo commented Aug 12, 2016

@soumak77 Its functional. Please give it a try.

@tunecino
Copy link

I like the idea of 2 templates. Yii2 which is a PHP framework introduced 2 templates, and it worked as it allowed introducing all solid stuff and complex architecture via an advanced one while also maintaining a basic version not only for newcomers but also for small projects with less requirements.

the basic template in this case may use the built-in front-router which is great for small projects or non-angular developers while in a future we may also have an advanced one using ui-router instead, webpack, ... and a component based architecture maybe a little bit like this structure.

@soumak77
Copy link
Contributor Author

@tolyo I'm getting the following errors

13 Aug 04:24:16 - warn: Loading of html-pages-brunch failed due to Cannot find module 'mkdirp'
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.
13 Aug 04:24:16 - error: Initialization error -  Cannot read property 'brunchPluginName' of null 
Stack trace was suppressed. Run with `LOGGY_STACKS=true` to see the trace.

Also, I think jquery should be removed as a dependency as angular provides the required functionality via jqlite.

@tolyo
Copy link
Contributor

tolyo commented Aug 13, 2016

@soumak77 OS?

@tolyo
Copy link
Contributor

tolyo commented Aug 13, 2016

@soumak77 Plz try again w clean install

@soumak77
Copy link
Contributor Author

@tolyo it's working now

@soumak77
Copy link
Contributor Author

@tolyo I just published a prerelease for 2.0 so that we can get the template working with that version. The prerelease is https://github.com/base-apps/angular-base-apps/releases/tag/v1.2.7-0.

soumak77 added a commit to base-apps/angular-base-apps-template that referenced this issue Aug 14, 2016
@soumak77
Copy link
Contributor Author

I got the angular base apps docs updated to work with angular-icons, but couldn't figure out how to get the brunch build updated for the templates. Since the iconic source fails on the import command, it'll likely need to be included outside of app.js.

The new angular-dynamic-routing and angular-icons modules should be refactored a bit so that they are ES6 compliant (i.e. work well with import).

soumak77 added a commit to base-apps/angular-base-apps-template that referenced this issue Aug 20, 2016
@soumak77
Copy link
Contributor Author

I updated the template to work with angular-icons v1.0

@soumak77
Copy link
Contributor Author

@tolyo all prerequisites for the template are now completed. Could you look into hooking up the base-apps-router module to run with the template build? I'm not sure what the proper config is to get a pre-build step to run in brunch/babel.

@tolyo
Copy link
Contributor

tolyo commented Aug 23, 2016

@soumak77 Please give it a test drive.

@soumak77
Copy link
Contributor Author

@tolyo base-apps-router has been updated to not require gulp. Is there a way to run it with just babel/brunch so the gulp dependency can be removed?

@gakimball any suggestions on how to update the build to accomplish this?

@tolyo
Copy link
Contributor

tolyo commented Aug 23, 2016

@soumak77 I thought it was a gulp task. Can we update the docs to reflect this?

@soumak77
Copy link
Contributor Author

@tolyo changes were made by @gakimball the other day to allow running outside of gulp (base-apps/base-apps-router@4cb5be0)

I'll update the base-apps-router README to include a non-gulp example.

soumak77 added a commit to base-apps/angular-base-apps-template that referenced this issue Aug 25, 2016
soumak77 added a commit that referenced this issue Aug 26, 2016
@soumak77
Copy link
Contributor Author

template is ready to start using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants