-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork foundation Templates #32
Comments
@soumak77 Do we need the cli? I don't see the point of it. I will get around the template ASAP. |
@tolyo whatever steps the CLI performs we can just add to the documentation |
@soumak77 We have two npm repoes right now. Please unpublish the unused one. |
@tolyo I tried but the command failed. I opened an issue on npm: npm/npm#13632 |
@soumak77 Roger |
@tolyo what is the reason for replacing To accommodate all developers, we can create the same template with different build tools. I personally would want to have a gulp build when using the template. The gulp build should also be the default template since the framework uses gulp. Also, the dynamic routing plugin is built with gulp, so I'm not sure if that will have issues running with brunch. |
duplicate npm package has been removed |
@soumak77 Because it takes more code in |
@tolyo understood and I like that direction, but I still think a separate gulp template should be created so that users have options. I personally have never heard of brunch, so if I was new to this framework, I wouldn't like having to learn a separate build system on top of the framework itself. |
@soumak77 This is a sample to try the framework with sensible and modern defaults and not a reference on how the framework should be used. Feel free to replace it with Gulp or Grunt, but the previous version of the template is legacy. |
@soumak77 This isn't close to being done. I want to add sample apps to this: a) a chat app b) a dashboard app and c) task management app |
@tolyo looking forward to it! We can use github pages to host the apps like we do with the docs. I integrated https://www.npmjs.com/package/gh-pages into the framework build to auto-publish the docs. |
@soumak77 I've been looking around for a solid Gulp ES6 stack and they all use Webpack. So it would require an introduction of yet another tool. |
@tolyo On an enterprise scale, the build systems can get pretty complex and I would like to have a template that understands this and makes it easy to build scalable apps from the start. At the same time, I don't want too complex of a build that new comers are off put by using the framework just to hack something together. Not sure if that helps, but that's my thinking. If trying to make the base template requires too much upfront knowledge, we can maybe split the template into basic and enterprise versions. |
@soumak77 Shooting just for minimal code for now. |
@tolyo sounds good. I want to have a template available for the 2.0 release, so let me know when you get it working for 1.x and I can migrate it to 2.x. |
@soumak77 Its functional. Please give it a try. |
I like the idea of 2 templates. Yii2 which is a PHP framework introduced 2 templates, and it worked as it allowed introducing all solid stuff and complex architecture via an advanced one while also maintaining a basic version not only for newcomers but also for small projects with less requirements. the basic template in this case may use the built-in front-router which is great for small projects or non-angular developers while in a future we may also have an advanced one using ui-router instead, webpack, ... and a component based architecture maybe a little bit like this structure. |
@tolyo I'm getting the following errors
Also, I think jquery should be removed as a dependency as angular provides the required functionality via jqlite. |
@soumak77 OS? |
@soumak77 Plz try again w clean install |
@tolyo it's working now |
@tolyo I just published a prerelease for 2.0 so that we can get the template working with that version. The prerelease is https://github.com/base-apps/angular-base-apps/releases/tag/v1.2.7-0. |
I got the angular base apps docs updated to work with angular-icons, but couldn't figure out how to get the brunch build updated for the templates. Since the iconic source fails on the import command, it'll likely need to be included outside of app.js. The new |
I updated the template to work with angular-icons v1.0 |
@tolyo all prerequisites for the template are now completed. Could you look into hooking up the |
@soumak77 Please give it a test drive. |
@tolyo base-apps-router has been updated to not require gulp. Is there a way to run it with just babel/brunch so the gulp dependency can be removed? @gakimball any suggestions on how to update the build to accomplish this? |
@soumak77 I thought it was a gulp task. Can we update the docs to reflect this? |
@tolyo changes were made by @gakimball the other day to allow running outside of gulp (base-apps/base-apps-router@4cb5be0) I'll update the base-apps-router README to include a non-gulp example. |
template is ready to start using |
The text was updated successfully, but these errors were encountered: