-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OptimismMintableERC20Factory implementation #158
Conversation
|
||
Note: there have been reports of some folks seeing this error `Error creating signer: error opening ledger: hidapi: failed to open device`. A fix is in progress, but not yet merged. If you come across this, open a new terminal and run the following to resolve the issue: | ||
``` | ||
git clone git@github.com:base-org/eip712sign.git | ||
cd eip712sign | ||
go install | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no longer relevant with the updated eip712 signer go lib.
Make sure you are on the "Overview" tab of the tenderly simulation, to | ||
validate integrity of the simulation, we need to check the following: | ||
|
||
1. "Network": Check the network is Optimism Mainnet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. "Network": Check the network is Optimism Mainnet. | |
1. "Network": Check the network is Base Mainnet. |
'@rari-capital/solmate/=lib/solmate/', | ||
'@base-contracts/=lib/base-contracts', | ||
'solady/=lib/solady/src/', | ||
'@agora=lib/optimism-gov/src', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove agora
address internal BASE_SAFE = vm.envAddress("BASE_SAFE"); | ||
address internal OP_SAFE = vm.envAddress("OP_SAFE"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These aren't needed in the script's context and can be safely removed.
This PR add the
RunUpgradeToAndCallERC20Factory
to upgrade theOptimismMintableERC20Factory
implementation, at address 0x4200000000000000000000000000000000000012, to point to the newly deployed factory at address 0x6922ac4DbDfEdEa3a1E5535f12c3171f2b964C91, effectively replacing the old implementation at address 0xc0D3c0d3C0d3c0d3c0D3c0d3c0D3c0D3c0D30012.