✨ feat: Add gas estimation actions #67
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| /** | ||
| * Estimate the l1 gas price portion for a transaction | ||
| * @example | ||
| * const price = await getL1GasPrice(publicClient, { | ||
| * blockNumber, | ||
| * blockTag, | ||
| * }); | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * Estimate the l1 gas price portion for a transaction | |
| * @example | |
| * const price = await getL1GasPrice(publicClient, { | |
| * blockNumber, | |
| * blockTag, | |
| * }); | |
| */ |
Maybe delete for now and go through and add jsdocs in it's own pr
There was a problem hiding this comment.
yeah I've been underinvesting in jsdoc in favor of the markdown docs, not sure if right tradeoff.
There was a problem hiding this comment.
Jsdoc is more important because you see jsdoc in your editor imo
| // no way to get historical gas price | ||
| createPublicClient: (...args: [any]) => { | ||
| const client = _viem.createPublicClient(...args) | ||
| client.getGasPrice = async () => parseGwei('0.00000042') |
There was a problem hiding this comment.
does getGasPrice not work with normal forking?
There was a problem hiding this comment.
It does not unfortunately. Viem types correctly don't give you blockTag as a param as well
src/actions/public/L2/feeActions.ts
Outdated
| * const contract = getGasPriceOracleContract(publicClient) | ||
| * const gasPrice = await contract.read.gasPrice({ blockNumber }) | ||
| */ | ||
| const getGasPriceOracleContract = <TChain extends Chain | undefined>( |
There was a problem hiding this comment.
again prefer 1 function per file.
Thinking if we should actually export these viem versions of all the main contracts 🤔
There was a problem hiding this comment.
@eth-optimism/contracts-ts is the package that exports versions of all the main contracts. It does it both as react hooks and as vanilla hooks. It might be a good idea to reexport them from this package though
| // no way to get historical gas price | ||
| createPublicClient: (...args: [any]) => { | ||
| const client = _viem.createPublicClient(...args) | ||
| client.getGasPrice = async () => parseGwei('0.00000042') |
There was a problem hiding this comment.
It does not unfortunately. Viem types correctly don't give you blockTag as a param as well
src/actions/public/L2/feeActions.ts
Outdated
| * const contract = getGasPriceOracleContract(publicClient) | ||
| * const gasPrice = await contract.read.gasPrice({ blockNumber }) | ||
| */ | ||
| const getGasPriceOracleContract = <TChain extends Chain | undefined>( |
There was a problem hiding this comment.
@eth-optimism/contracts-ts is the package that exports versions of all the main contracts. It does it both as react hooks and as vanilla hooks. It might be a good idea to reexport them from this package though
| /** | ||
| * Estimate the l1 gas price portion for a transaction | ||
| * @example | ||
| * const price = await getL1GasPrice(publicClient, { | ||
| * blockNumber, | ||
| * blockTag, | ||
| * }); | ||
| */ |
There was a problem hiding this comment.
Jsdoc is more important because you see jsdoc in your editor imo
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
994411a
to
8adc3e2
Compare
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
ab6e31f
to
abce50a
Compare
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
abce50a
to
206b473
Compare
| * args: [address], | ||
| * }); | ||
| */ | ||
| export const estimateFees: EstimateFees = async (client, options) => { |
There was a problem hiding this comment.
in an ideal world, this would be the default estimateGas function for an OPStack chain in viem, right? @roninjin10
Do we think we should name it like opStackEstimateGas or something closer?
There was a problem hiding this comment.
Estimate gas is different. On l1 estimate fees would be estimateGas multiplied by the gas price. This is something I chatted with Jake about and he lightly agreed it would be valuable to add for all chains
There was a problem hiding this comment.
ok thanks for clarifying @roninjin10
There was a problem hiding this comment.
I’m not in love with the name estimateFees btw I just couldn’t come up with a better name. Etherscan calls it a transactionFee. Maybe we should call it transactionFee? I would love a name that makes it so folks can guess the difference between it and estimateGas most of the time
There was a problem hiding this comment.
transactionFee is pretty good! I don't have a strong preference
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
7b44eea
to
9e640aa
Compare
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
9e640aa
to
a3d7ef5
Compare
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
a3d7ef5
to
6de7647
Compare
roninjin10
force-pushed
the
09-12-feat_Add_gas_estimation_actions
branch
from
96d4f79
to
ca4bb91
Compare
versionandl1BaseFee. The recommended way to use this is to just use the gasPriceOracle contract or get stuff like l1BaseFee from l1 they just bloat the API including them here imo