Fixed shell templates. #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were broken in three ways: 1. They had leftover junk from a mustache template that was blocking the hashbang. 2. They had double quotes where single quotes were needed. 3. They were checking for interactive mode in a way that's incompatible with fish_shell. I just deleted the check; I suspect that that's the sort of check the user should do before calling the file (rather than the sort of check that should be done by the file itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were broken in three ways:
hashbang.
with fish_shell. I just deleted the check; I suspect that that's the
sort of check the user should do before calling the file (rather than
the sort of check that should be done by the file itself).