Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert from running ciinabox-ecs as rake tasks to gem #107

Merged
merged 3 commits into from
May 14, 2018

Conversation

toshke
Copy link
Contributor

@toshke toshke commented Mar 23, 2018

Allow running ciinabox-ecs as a gem

By embedding gem version if root stack template, and outputting as stack parameter, mass management of ciinabox-ecs installations becomes easier (versions are tracked). If Rakefile method is used rather than gem, short git sha1 will be embedded and outputted as ciinabox version. Aside from binary version, vanity version number coming out of ciinabox config is rendered into template description as well.

Cli commands structure

Gem is not full replacement of Rake tasks, but mere wrapper around them. It improves usability by allowing user to run command from ciinaboxes directory, without the need to specify it explicitly through CIINABOXES_DIR variable or relying on default ciinaboxes dir. Ciinabox name is always taken as last argument of cli command, with install and full_install commands being without ciinabox argument.

E.g. ciinabox-ecs generate deploy update myciinabox will result in following rake equiqalent

CIINABOXES_DIR=$PWD CIINABOX=myciinabox rake ciinabox:generate ciinabox:deploy ciinabox:update

Generic cli structure would be

ciinabox-ecs action1 action2 .. actionN ciinabox_name

Help can be obtained by running

ciinabox-ecs help

As for CIINABOXES_DIR and CIINABOX environment variables, they are still taken in account when running gem. In case CIINABOX environment variable is present, there is no need to specify ciinabox name as last argument, as it will be automatically assumed from environment.

Artifactory service

As work on artifactory service was done and tested in parallel with conversion to gem, this PR includes documentation and code for that service.

@toshke toshke force-pushed the feature/gemify branch 6 times, most recently from a538490 to e4f7aef Compare March 27, 2018 23:36
@aaronwalker aaronwalker self-requested a review May 14, 2018 00:34
Copy link
Member

@aaronwalker aaronwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronwalker aaronwalker merged commit 126885b into base2Services:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants