Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where calling any RDS cluster function would include docdb resource's if they were present. As such docdb snapshots would be created and removed if any RDS cluster actions were invoked.
Example of issue:
For this example we have a stack with both a
docdb
andrds_cluster
resource. No snapshots have been created yet for either.We call
shelvery create_backups rds_cluster
We can observe in the logs immediately that shelvery has picked up the
docdb_cluster
as a resource to backup alongside our actualrds cluster
.Shelvery creates a snapshot of the
doc db cluster
aswell as a snapshot for the actualRDS cluster
.Example of fix:
The solution was to remove any clusters from the list of clusters returned which had
Engine='docdb'
shelvery create_backups rds_cluster