Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/unit tests refactor #146

Merged
merged 23 commits into from
Apr 24, 2023
Merged

Feature/unit tests refactor #146

merged 23 commits into from
Apr 24, 2023

Conversation

tarunmenon95
Copy link
Contributor

@tarunmenon95 tarunmenon95 commented Apr 24, 2023 •
edited

Refactored Unit Tests

Changelog

  • Fixed another bug in RDS Cluster where cleanup would remove docdb snapshots
  • Added resource waiters for all resources during test setups
  • Refactored to use custom retention type of 1 second, allows us to leverage inbuilt shelvery functionality to cleanup snapshots
  • Bunch of refactoring
  • Updated readme to include shelvery_reencrypt_kms_key_id description

Tests fixed

  • Fixes issue with RDS Cluster test failing due to docdb resources getting pulled inadvertently
  • Fixes EBS test failling sporadicly due to invalid resources in s3 bucket from manual deletes via client instead of via shelvery cleanup
  • Fixes issue with calling create backup when resources aren't ready for all tests

@tarunmenon95 tarunmenon95 linked an issue Apr 24, 2023 that may be closed by this pull request
Fix unit tests #143
Closed
@tarunmenon95 tarunmenon95 merged commit 40655d0 into base2Services:develop Apr 24, 2023
2 checks passed
tarunmenon95 added a commit that referenced this pull request Apr 26, 2023
@tarunmenon95
Merge pull request #146 from base2Services/develop (#147)
e84f8f4 
* exlude docdb from rds cluster backups

* Feature/unit tests refactor (#146)

* Initial add

* Disabled non docdb tests

* Disabled non doc db stack resources

* Fixed up set up test func

* Changed waiter to rds

* Fixed client call

* Enable docdb pull test

* Fixed bugs

* Fixed typo

* Fixed share id

* Fixed docdb pull test

* Disable docdb, enable rds instance

* Fixed rds waiter

* Enabled cloudformation for RDS Instance

* Updated refactored unit tests

* Removed test teardowns

* Moved cleanup before assertion

* Added fix for rds cluster docdb cleanup

* Refactored unit tests

* Re-enabled stack create

* Removed bucket delete

* Moved s3Upload outside script block in pipeline

* Moved s3upload back into script block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guslington Guslington Guslington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unit tests
2 participants
@tarunmenon95 @Guslington