Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor Bulma's minified CSS directly in the gem.
If the app importing Audits1984 uses a Content Security Policy, it won't be able to import the stylesheet from https://cdn.jsdelivr.net without explicitly allowing it in the policy. Bundling the stylesheet with the app is a simple way to fix this issue.
(Arguably it's also better practice from a security standpoint for an auditing tool to avoid making any requests to third parties.)
The minified CSS is still 202KiB large, so if you think that's too large to include as part of the gem, I can instead submit a PR to customize the CSP specifically for Audits1984's controller actions. It wouldn't be too difficult to implement, but it'd be less user-friendly as it should probably be an opt-in flag (since you probably don't want to start tweaking the CSP in apps that don't have a CSP in the first place).
cc @jorgemanrubia @dhh