Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add given name and family name to identity functions #25

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Add given name and family name to identity functions #25

merged 2 commits into from
Jan 15, 2019

Conversation

asc-ioki
Copy link
Contributor

In their response, google exposes given_name and family_name. See https://developers.google.com/identity/sign-in/web/server-side-flow at the very bottom of the page.

The way I am using google_sign_in, I need access to this data and the cleanest way to get it would be for the gem itself to expose it.

@klaustopher
Copy link

Hey there,

I am mentoring @annesc in a project she is currently implementing.

I looked into the failing tests on this PR and this is not caused by anything that @annesc added here. The 2.2 tests are failing because Travis tries to install the current bundler (2.0.1) but that requires a newer Rubygems version. For Ruby 2.2 you have to install an older version of bundler (1.17.3).

Should we add the travis config changes here or in a seperate PR to get the tests passing?

@georgeclaghorn
Copy link
Contributor

Thanks, @klaustopher! We can fix Travis separately.

Sorry for the delay in reviewing. I’ll take a look later today.

@georgeclaghorn georgeclaghorn merged commit b9bd609 into basecamp:master Jan 15, 2019
@georgeclaghorn
Copy link
Contributor

Thanks, @annesc!

@asc-ioki
Copy link
Contributor Author

Thank you for including this, @georgeclaghorn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants