Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple values for same docker run argument #307

Closed
jacoscaz opened this issue May 23, 2023 · 1 comment
Closed

Multiple values for same docker run argument #307

jacoscaz opened this issue May 23, 2023 · 1 comment

Comments

@jacoscaz
Copy link

The --add-host argument to docker run can be repeated multiple times to add more hosts:

docker run --add-host one:X.X.X.X --add-host two:Y.Y.Y.Y ...

Support for custom docker run arguments was added in #95 but the optionize function at https://github.com/mrsked/mrsk/blob/4e9c39f26df6b0b6da9deb2517c51252d4b7df03/lib/mrsk/utils.rb#L30 doesn't appear to support array-like values.

Is this something you would like to support? Would you accept a PR? It's my very first time reading and writing Ruby but this seems easy enough.

@jacoscaz
Copy link
Author

jacoscaz commented May 23, 2023

Nevermind, I'm an idiot. Of course I have found the solution only after posting this. Looked into the code some more and this is possible:

    options:
      "add-host": 
        - one:X.X.X.X
        - two:Y.Y.Y.Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant