Log uncommitted changes during deploy #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmb
requested changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks @igor-alexandrov, this looks like a good change! Just one request to update the message.
djmb
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRSK adds
uncommittedsuffix to the image name if there are any not committed files during deploy process. On the one side this is super helpful, when you deploy from your local host. On the other side this causes some problems during deploy from CD – you don't know what exactly changed during CD process (actions may leave some garbage after them). To find out what should be added to.gitignore, I usually add additional step to the job, which runsgit status --porcelain.Other users also have such questions: #378.
This PR adds logging of uncommitted changes before
MRSK.builder.pushcommand.