Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picking the first available role on primary_host #428

Merged
merged 1 commit into from Aug 24, 2023

Conversation

tbuehlmann
Copy link
Contributor

4dd8208 introduced a bug:

MRSK.primary_host.roles.first

MRSK.primary_host is an IP Address as a string, so calling roles on it raises an error.

@tbuehlmann tbuehlmann marked this pull request as ready for review August 24, 2023 11:58
@dhh dhh merged commit 338fd4e into basecamp:main Aug 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants