Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require missing net/scp dependency #645

Merged
merged 1 commit into from Mar 4, 2024

Conversation

juan-apa
Copy link
Contributor

@juan-apa juan-apa commented Jan 11, 2024

Preface

A couple of days ago, the github actions I have that automate the deployment of rails apps with kamal, started failing when running kamal envify, with the following error:

<internal:/Users/juan/.rbenv/versions/3.2.2/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- net/scp (LoadError)
  ...

I tracked down the issue to one of the most recent releases of capistrano/sshkit, which removed require 'net/scp'
The capistrano release which no longer requires net/scp is v1.22.0 introduced in capistrano/sshkit#524

Steps to reproduce

  • install kamal on a fresh ruby environment
  • run any command which makes use of scp functionality (e.g. kamal envify)

The fix

  • adding the require explicitly in lib/kamal/sshkit_with_ext.rb brings back the scp functionality.

I believe this is very similar to #635 which @mdkent did 2 weeks ago

This change fixes #644

@djmb
Copy link
Collaborator

djmb commented Mar 4, 2024

Thank's for the PR 🙏

@djmb djmb merged commit bcfd0ca into basecamp:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kamal fails to load net/scp on fresh ruby install
4 participants