Skip to content
This repository has been archived by the owner on Mar 2, 2020. It is now read-only.

Use an iframe for displaying mail contents #21

Closed
wants to merge 1 commit into from
Closed

Use an iframe for displaying mail contents #21

wants to merge 1 commit into from

Conversation

joeljunstrom
Copy link

Be sure you do not interfere with the email rendering

We've had issues with some of our emails not displaying correctly (most often because the message header would overlap the email message)

This is a bit of a hackish solution adding another request to display the email within a iframe so might just be regarded as a point of discussion but sharing is caring so here goes.

@jeremy
Copy link
Member

jeremy commented Mar 30, 2012

Interesting idea. Anyone else tried this?

@akshayrawat
Copy link

@joeljunstrom @jeremy - Ran into this exact same problem today. The pull request above fixes it, confirmed!

@akshayrawat
Copy link

@joeljunstrom @jeremy

This shows a dialog box which has an iframe showing the mailview contents

This problem was actually fixed on master a couple of months ago, and has not been released as a gem yet. That fixes this problem, unless @joeljunstrom fixed more problems we can close this issue (and please release an updated gem).

Thanks.

@joeljunstrom
Copy link
Author

I think the fix on master most probably solved most (all?) problems.
But since styling for email clients is iffy at best I want the security of knowing that doubled body tags etc. does not compromise the rendering.

@jonleighton
Copy link
Contributor

+1 to this

This is to be sure To be sure you do not interfere with rendering.
@look
Copy link

look commented Sep 21, 2012

I would like to see this because it would make it easier to upload the mail to an email testing service, like Litmus.

@jeremy
Copy link
Member

jeremy commented Aug 9, 2013

Thanks @joeljunstrom! Merged #34.

@jeremy jeremy closed this Aug 9, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants