Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use an iframe for displaying mail contents #21

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

Be sure you do not interfere with the email rendering

We've had issues with some of our emails not displaying correctly (most often because the message header would overlap the email message)

This is a bit of a hackish solution adding another request to display the email within a iframe so might just be regarded as a point of discussion but sharing is caring so here goes.

Owner

jeremy commented Mar 30, 2012

Interesting idea. Anyone else tried this?

@joeljunstrom @jeremy - Ran into this exact same problem today. The pull request above fixes it, confirmed!

@joeljunstrom @jeremy

This shows a dialog box which has an iframe showing the mailview contents

This problem was actually fixed on master a couple of months ago, and has not been released as a gem yet. That fixes this problem, unless @joeljunstrom fixed more problems we can close this issue (and please release an updated gem).

Thanks.

I think the fix on master most probably solved most (all?) problems.
But since styling for email clients is iffy at best I want the security of knowing that doubled body tags etc. does not compromise the rendering.

Contributor

jonleighton commented Sep 11, 2012

+1 to this

Use an iframe for displaying mail contents
This is to be sure To be sure you do not interfere with rendering.

look commented Sep 21, 2012

I would like to see this because it would make it easier to upload the mail to an email testing service, like Litmus.

Owner

jeremy commented Aug 9, 2013

Thanks @joeljunstrom! Merged #34.

@jeremy jeremy closed this Aug 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment