This repository has been archived by the owner on Mar 2, 2020. It is now read-only.
Fix inline attachments #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TMail doesn't work on 1.9.
The top-level parts aren't necessarily where the relevant e.g. text/html part actually is. For example there might be a top-level multipart/alternative container which contains the text/html. This happens when Action Mailer is used with inline attachments.
|
Is there a trick I'm missing to getting these to display? The inline attachments work fine when sent to GMail, but not in MailView.
via afeld/tricle#60 |
|
I see the same behavior as @afeld using mail_view 2.0.4, rails 4.0.4. The mail_view page shows the inline attachment in the Attachments list but the page renders using the cid url for the image. I can see how this may be expected behavior but then it would be useful to be able to cross-reference the cid and verify the inline attachment is referenced correctly in the attachment list. Alternatively, rendering the inline content as a data-uri, etc. might give the best visualization experience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see my commentary on #17. This is a fix which includes a test. I've also made a couple of commits which were necessary for me to successfully be able to run the tests, hope that's ok.
This essentially supersedes #17 so that can be closed if this gets merged.