Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemspec ignore test files for reduce gem size from 7.5MB to 7.5KB #11

Merged

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Sep 15, 2018

https://rubygems.org/gems/marcel

For reduce ActiveStorage size

-- -rw-r--r--   1 jason  staff   7.5M  9 15 10:34 marcel-0.3.2.gem
++ -rw-r--r--   1 jason  staff   7.5K  9 15 10:45 marcel-0.3.2.gem

2018-09-15 10 37 38

@huacnlee huacnlee changed the title Gemspec ignore test files for reduce gem size from 7.5MB to 6KB Gemspec ignore test files for reduce gem size from 7.5MB to 7.5KB Sep 15, 2018
@huacnlee huacnlee force-pushed the fix-test-file-including-rubygem branch from cad80cc to 94516b3 Compare September 15, 2018 02:46
@georgeclaghorn
Copy link
Contributor

Wow, thank you!

@georgeclaghorn georgeclaghorn merged commit ab9c543 into rails:master Sep 15, 2018
@huacnlee huacnlee deleted the fix-test-file-including-rubygem branch September 15, 2018 02:58
@huacnlee
Copy link
Contributor Author

ActiveStorage has dependency this gem by using marcel ~> 0.3.1, so maybe if you can release a new version 0.3.3, the issue can fix now.

@georgeclaghorn
Copy link
Contributor

I just published version 0.3.3. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants