Skip to content

Commit

Permalink
Address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sinjo committed Dec 15, 2014
1 parent e385cac commit 15937ac
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 17 deletions.
2 changes: 1 addition & 1 deletion lib/marginalia/comment.rb
Expand Up @@ -27,7 +27,7 @@ def self.clear!

private
def self.application
if defined?(Rails.application) && Rails.application.present?
if defined?(Rails.application)
Marginalia.application_name ||= Rails.application.class.name.split("::").first
else
Marginalia.application_name ||= "rails"
Expand Down
30 changes: 14 additions & 16 deletions test/query_comments_test.rb
Expand Up @@ -4,21 +4,24 @@ def using_rails_api?
ENV["TEST_RAILS_API"] == true
end

def using_new_minitest?
Gem::Version.new(Rails::VERSION::STRING) >= Gem::Version.new('4.1')
end

if using_new_minitest?
require "minitest/autorun"
else
require "test/unit"
end
require "minitest/autorun"
require 'mocha/test_unit'
require 'logger'
require 'pp'
require 'active_record'
require 'action_controller'
require 'rails'

# Shim for compatibility with older versions of MiniTest
MiniTest::Test = MiniTest::Unit::TestCase unless defined?(MiniTest::Test)

# From version 4.1, ActiveRecord expects `Rails.env` to be
# defined if `Rails` is defined
if defined?(Rails) && !defined?(Rails.env)
module Rails
def self.env
end
end
end

if using_rails_api?
require 'rails-api/action_controller/api'
Expand Down Expand Up @@ -70,13 +73,8 @@ def driver_only

Marginalia::Railtie.insert

if using_new_minitest?
TestRunnerClass = MiniTest::Test
else
TestRunnerClass = Test::Unit::TestCase
end

class MarginaliaTest < TestRunnerClass
class MarginaliaTest < MiniTest::Test
def setup
@queries = []
ActiveSupport::Notifications.subscribe "sql.active_record" do |*args|
Expand Down

0 comments on commit 15937ac

Please sign in to comment.