Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest ruby versions to test suite #69

Merged
merged 2 commits into from
Jul 29, 2018
Merged

Add latest ruby versions to test suite #69

merged 2 commits into from
Jul 29, 2018

Conversation

shaneog
Copy link
Contributor

@shaneog shaneog commented Apr 11, 2018

Ruby 2.4.4
Ruby 2.5.1

@shaneog shaneog mentioned this pull request Apr 11, 2018
@arthurnn
Copy link
Collaborator

arthurnn commented May 9, 2018

@shaneog Thanks for the PR. Can you fix the merge conflicts and make sure it is green.. thanks

The 'mysql' gem hasn't been (and won't be) updated to work with
RUBY_INTEGER_UNIFICATION (see https://bugs.ruby-lang.org/issues/12005).

See also luislavena/mysql-gem#32.
@shaneog
Copy link
Contributor Author

shaneog commented May 14, 2018

@arthurnn Done.

@oyeanuj
Copy link

oyeanuj commented Jul 27, 2018

@arthurnn @shaneog Is this ready to merge?

@arthurnn arthurnn merged commit a61ac25 into basecamp:master Jul 29, 2018
@shaneog shaneog deleted the ruby-2.5 branch July 30, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants