Dev Env Tweaks #156
Open
Dev Env Tweaks #156
+70
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works for all JavaScript envs, including React and others
gcavanunez
reviewed
Jun 19, 2024
install/select-dev-env.sh
Outdated
| @@ -9,10 +9,16 @@ for language in $languages; do | |||
| ;; | |||
| Node.js) | |||
| mise use --global node@lts | |||
|
|
|||
| # Enable the extras plugins in NeoVim | |||
| jq '.extras |= (. + ["lazyvim.plugins.extras.lang.typescript"] | unique)' ~/.config/nvim/lazyvim.json >tmp.json && mv tmp.json ~/.config/nvim/lazyvim.json | |||
install/select-dev-env.sh
Outdated
| jq '.extras |= (. + ["lazyvim.plugins.extras.lang.php"] | unique)' ~/.config/nvim/lazyvim.json >tmp.json && mv tmp.json ~/.config/nvim/lazyvim.json | ||
|
|
||
| # Configure PHP's LSP to use intelephense instead of phpactor (default) | ||
| if ! grep -q 'php_lsp' ~/.config/nvim/lua/config/options.lua; then |
florentdestremau
approved these changes
Jun 19, 2024
csfh
reviewed
Jun 22, 2024
There was a problem hiding this comment.
Seems good to me. The only thing I would change is create a temporary file using mktemp and possibly a tiny refactor to re-use the mv $OMAKUB_LAZYVIM_TMP ~/.config/nvim/lazyvim.json at the end of the switch, since this seems to be a common statement in most of the cases anyway.
Using mktemp should ensure that we get a fresh clean file every time and there don't somehow end up using a corrupt or bad tmp.json (think other programs, or aborted executions).
OMAKUB_LAZYVIM_TMP=$(mktemp /tmp/omakub.XXXXXX)
...
rm "$OMAKUB_LAZYVIM_TMP"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed