This repository has been archived by the owner on May 15, 2020. It is now read-only.
Stricter http-proxy version #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing issues getting the tests to pass for the proxy-to-port patch that's in master. After a bit of investigation it seems that the newer versions of node-http-proxy (>= 0.6) have changed their API.
Pow uses the 0.5.x API for HttpProxy, which is not compatible with the newer API.
This patch takes the "easy" option and locks the dependency down to the 0.5.x API. It may, however, be preferable to upgrade pow to use the newer API.