Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoureMappingURL points to minified source map that does not exist on Trix 2.0.4 #1033

Closed
maxwell opened this issue Dec 28, 2022 · 3 comments · Fixed by #1098
Closed

SoureMappingURL points to minified source map that does not exist on Trix 2.0.4 #1033

maxwell opened this issue Dec 28, 2022 · 3 comments · Fixed by #1098

Comments

@maxwell
Copy link
Contributor

maxwell commented Dec 28, 2022

on 2.0.4, when I run yarn build, I get the following DEBUG message
● [DEBUG] Failed to read file "node_modules/trix/dist/trix.esm.min.js.map": open .../node_modules/trix/dist/trix.esm.min.js.map: no such file or directory

When I look in the trix folder in node_modules

I see

node_modules/trix/dist/trix.esm.js but not node_modules/trix/dist/trix.esm.min.js

I'm not sure if this is a build and release config issue, or something on my install end. Anyone have any ideas?

@maxwell maxwell changed the title SoureMappingURL is incorrect SoureMappingURL points to minified source map that does not exist on Trix 2.0.4 Dec 28, 2022
@maxwell
Copy link
Contributor Author

maxwell commented Feb 4, 2023

An interesting is that I just built trix from yarn build and the sourcemap trix.esm.min.js.map is present there.

But when I look at the code of the latest release on npm, I don't see the file: https://www.npmjs.com/package/trix?activeTab=explore

I know the past versions of Trix were in CoffeeScript, so that might have made Source Maps hard to vendor? #885? Is it possible something in the release script is stripping them out?

@amhunt
Copy link

amhunt commented Oct 2, 2023

We're also experiencing this on 3.0.6 - @afcapel any ideas? Not a huge deal, but would be great to fix!

@afcapel
Copy link
Contributor

afcapel commented Oct 3, 2023

We were not including .map files in the npm files. Should be fixed in #1098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants