Allow customizing the table separator #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afcapel
reviewed
Oct 31, 2022
kevinmcconnell
force-pushed
the
customise-table-separator
branch
from
e96c0ef
to
78513c5
Compare
|
@afcapel Thanks for the review. I've updated this per your feedback, if you fancy taking another look? |
afcapel
reviewed
Nov 3, 2022
When parsing HTML with tables, Trix converts the table contents into a
simple plain text version, using separators between cells and rows. By
default, pipes and newlines are used to format tables like:
one | two
three | four
In some cases we may want to change how this formatting happens. To
allow this, we add some new parser-specific config options, under
`config.parser`:
- `tableCellSeparator` (default `" | "`)
- `tableRowSeparator` (default `"\n"`)
- `removeBlankTableCells` (default `false`)
kevinmcconnell
force-pushed
the
customise-table-separator
branch
from
78513c5
to
2e9d935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tables are converted into plain text, Trix inserts a pipe symbol between cells.
In some cases we may want to change how this formatting happens. To allow this, we add some new parser-specific config options, under
config.parser:tableCellSeparator(default" | ")tableRowSeparator(default"\n")removeBlankTableCells(defaultfalse)