Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run yarn build-assets at the beginning of yarn start #1006

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Run yarn build-assets at the beginning of yarn start #1006

merged 1 commit into from
Oct 31, 2022

Conversation

shimbaco
Copy link
Contributor

When I ran yarn start command I got 404 error on localhost:8000.
This PR fixes the error by running yarn build-assets to copy static files.

afcapel
afcapel approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@afcapel afcapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@afcapel afcapel merged commit 2a0e178 into basecamp:v2 Oct 31, 2022
@shimbaco shimbaco deleted the v2-run-build-assets-at-the-beggining-of-yarn-start branch October 31, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afcapel afcapel afcapel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shimbaco @afcapel