Fix handling pastes in browsers that don't support ClipboardEvent.clipboardData #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when Trix received a paste event with no
clipboardData
, we'd do nothing and assume the mutation observer would detect the change and cause an HTML re-parse. But becauseTrix.MutationObserver
doesn't deeply traverse nodes, the mutation summary it returns could be empty depending on the pasted HTML. With a little logging, you can see this by inserting HTML into the editor:Instead of doing nothing, we can capture the paste using
getPastedHTMLUsingHiddenElement
, which a) fixes the problem of nothing pasting at all, and b) allows Trix to format insert the pasted HTML better.Pasting in IE11 before:
After: