Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if startContainer of range looks like a node before returning range #214

Closed
wants to merge 1 commit into from

Conversation

tedtate
Copy link

@tedtate tedtate commented Mar 21, 2016

Attempted work-around for: https://bugzilla.mozilla.org/show_bug.cgi?id=1258484
Fixes: #209

Aside: Can we 馃敟 this implementation of getDOMRange or is it still needed - https://github.com/basecamp/trix/blob/master/src/trix/observers/selection_change_observer.coffee#L48

@javan
Copy link
Contributor

javan commented Mar 22, 2016

Thanks @tedtate! I actually started looking into this after you opened the issue, but never pushed my fix. What do you think of #215?

I'm pretty sure it's the same issue as https://bugzilla.mozilla.org/show_bug.cgi?id=208427, which is merely 13 years old.

Can we 馃敟 this implementation of getDOMRange or is it still needed

Yup, that can be switched over to the shared helper.

@tedtate
Copy link
Author

tedtate commented Mar 22, 2016

Yah, your fix looks awesome. I will close this.

Thanks for looking in to it!

@tedtate tedtate closed this Mar 22, 2016
@tedtate tedtate deleted the check-if-range-valid branch March 22, 2016 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants