Use stream actions #6
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
initial
branch
from
d899977
to
f1eb3ab
Compare
jorgemanrubia
force-pushed
the
stream-actions
branch
from
a8549aa
to
8ccaf88
Compare
jorgemanrubia
force-pushed
the
stream-actions
branch
from
8ccaf88
to
3ada400
Compare
yshmarov
reviewed
Dec 9, 2023
| @@ -0,0 +1 @@ | |||
| <%= render "tasks/update", task: @task, project: @project %> | |||
There was a problem hiding this comment.
why do you use an extra _update partial in the update template?
There was a problem hiding this comment.
@yshmarov because I want to use the same content for:
- The controller response (
update.html.erb), which is not a partial, but an action template. - The broadcasted partial (
_update.html.erb).
It's just to reuse the same code in both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice this only creates one stream action for a specific action and broadcast (task update).