-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated platform channel test interface #770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbeusekom
requested changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but we cannot merge it since the required update of the flutter_test
package is not released to stable yet (note that the flutter_test
package is integrated into the Flutter framework).
…st_interface # Conflicts: # geolocator_platform_interface/CHANGELOG.md # geolocator_platform_interface/pubspec.yaml
mvanbeusekom
requested changes
Sep 17, 2021
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Migration
Currently the tests are failing due to breaking changes to the platform channel test interface
🆕 What is the new behavior (if this is a feature change)?
The platform channel test interface is migrated
💥 Does this PR introduce a breaking change?
Yes. Currently the changes are present in the flutter
master
channel, so this PR should be merged when the changes are also available on the flutterstable
channel.🐛 Recommendations for testing
Does not apply
📝 Links to relevant issues/docs
Does not apply
🤔 Checklist before submitting
master
.