Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated platform channel test interface #770

Merged
merged 13 commits into from
Sep 20, 2021

Conversation

florissmit1
Copy link
Contributor

@florissmit1 florissmit1 commented Jul 2, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Migration

⤵️ What is the current behavior?

Currently the tests are failing due to breaking changes to the platform channel test interface

🆕 What is the new behavior (if this is a feature change)?

The platform channel test interface is migrated

💥 Does this PR introduce a breaking change?

Yes. Currently the changes are present in the flutter master channel, so this PR should be merged when the changes are also available on the flutter stable channel.

🐛 Recommendations for testing

Does not apply

📝 Links to relevant issues/docs

Does not apply

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #770 (0f4510b) into master (46d0df2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #770    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1        17    +16     
  Lines           27       242   +215     
==========================================
+ Hits            27       242   +215     
Impacted Files Coverage Δ
geolocator/lib/geolocator.dart
...rs/permission_definitions_not_found_exception.dart 100.00% <0.00%> (ø)
...orm_interface/lib/src/models/location_options.dart 100.00% <0.00%> (ø)
...orm_interface/lib/src/enums/location_accuracy.dart 100.00% <0.00%> (ø)
...ce/lib/src/errors/permission_denied_exception.dart 100.00% <0.00%> (ø)
...rors/permission_request_in_progress_exception.dart 100.00% <0.00%> (ø)
...face/lib/src/errors/position_update_exception.dart 100.00% <0.00%> (ø)
...src/implementations/method_channel_geolocator.dart 100.00% <0.00%> (ø)
...terface/lib/src/geolocator_platform_interface.dart 100.00% <0.00%> (ø)
...or_platform_interface/lib/src/models/position.dart 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d0df2...0f4510b. Read the comment docs.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but we cannot merge it since the required update of the flutter_test package is not released to stable yet (note that the flutter_test package is integrated into the Flutter framework).

@mvanbeusekom mvanbeusekom marked this pull request as draft July 5, 2021 11:55
florissmit added 2 commits September 17, 2021 10:13
…st_interface

# Conflicts:
#	geolocator_platform_interface/CHANGELOG.md
#	geolocator_platform_interface/pubspec.yaml
@florissmit1 florissmit1 marked this pull request as ready for review September 17, 2021 08:15
geolocator_platform_interface/CHANGELOG.md Outdated Show resolved Hide resolved
geolocator_platform_interface/pubspec.yaml Outdated Show resolved Hide resolved
florissmit1 and others added 5 commits September 17, 2021 10:37
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>
@mvanbeusekom mvanbeusekom merged commit 78c4db2 into master Sep 20, 2021
@mvanbeusekom mvanbeusekom deleted the platform_channel_test_interface branch September 20, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants