Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: use proper format of the secrets for onprem(local) setup #120

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

amiaynara
Copy link
Contributor

What does this PR do?

https://github.com/basepair/webapp/blob/c1ad441ec736e001f77b81b497001532c5b9fc16/www/bango/settings.py#L45 in settings.py of webapp expects the secrets as json which should look like:

{
  "api": {
     ...
  },
  ...
}

not like:

{"SecretString": '{"\n "api": ...}'}

This can also be seen in the case of aws_sm

secret = response.get('SecretString')

@amiaynara amiaynara changed the title Onprem testing BugFix: use proper format of the secrets for onprem(local) setup Jun 7, 2024
Copy link
Contributor

@SamkeetJain SamkeetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants