Improvement: Add the ability to download archived files, and wait whi… #92
Conversation
…le restore process is in progress
basepair/api.py
Outdated
| message = f'File {key} is present in {storage_class}' | ||
| if restore_status == 'restore_error': | ||
| message = f'File with key {key} does not exist or you dont have permission' | ||
| elif storage_class == 'DEEP_ARCHIVE' and restore_status != 'restore_complete': |
There was a problem hiding this comment.
I would create a if block for restore_status != 'restore_complete' and put the storage class in there. further, there should be a default file_status_check_interval value in case the file doesn't have either of these 2 storage classes.
There was a problem hiding this comment.
Something like this -
if storage_class == 'a':
interval = x
expected_time = '10-12 hours'
elif storage_class == 'b':
interval = y
expected_time = '2-5 minutes'
else:
interval = z
There was a problem hiding this comment.
In case the file doesn't have either of these 2 storage classes, we don't have to wait for file download. Because either the file is in STANDARD or does not exist, either way looks like there is no point in waiting, hence no need to set the interval. However, I have updated the code to have a default value, also refactored to reduce more lines of code.
|
Bump the version in basepair/init.py |
|
There is a pylint warning - |
…le restore process is in progress
Task: https://basepairtech.atlassian.net/browse/WEB-15