Attach Javadoc jar to build #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
attach-javadoc
branch
from
148bacc
to
6dbea48
Compare
|
Any specific reason (the javadoc jar does get built for releases) that it should also be built for every normal build? Happy to add it (the same is done for sources); in that case I would drop it from the oss release profile. |
|
Oh, I think release only is fine. I think the problem I had was that the non-OSS ones do not attach javadoc. So maybe the better fix is to add this to the non-OSS release profile. |
|
I consider closing this, as the javadoc jar is built as part of the release. |
hgschmie
pushed a commit
to hgschmie/basepom
that referenced
this pull request
Nov 23, 2016
hgschmie
pushed a commit
to hgschmie/basepom
that referenced
this pull request
Oct 29, 2019
Introduces a new setting "basepom.javadoc.skip" to skip the generation of javadoc jars. This is unconditionally turned off for the oss release profile. Fixes basepom#25.
hgschmie
pushed a commit
to hgschmie/basepom
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://maven.apache.org/plugin-developers/cookbook/attach-source-javadoc-artifacts.html