Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency-scope-maven-plugin #33

Merged
merged 2 commits into from Jul 6, 2017
Merged

Conversation

jhaber
Copy link
Contributor

@jhaber jhaber commented May 17, 2017

Readme for the plugin is here, background for the PR is in #30

@stevenschlansker
Copy link
Contributor

Tested on a couple of moderately complex projects - the only error reported was totally legit; we had junit sneaking into our build in a couple places. Initial impression is very positive!

@jhaber
Copy link
Contributor Author

jhaber commented Jun 14, 2017

Great! Our most common failures are related to junit/mockito/assertj sneaking in. I'm wondering if it's worth adding an exclusions parameter to the plugin so we can just ignore these libraries for convenience. In any case, those exclusions wouldn't belong in basepom so it probably doesn't affect this PR

@stevenschlansker
Copy link
Contributor

I found a couple more flags like you describe of junit. A couple of them were in integration tests that had unusual project layouts, I just disabled the plugin for that part of the tree. Still nothing particularly onerous.

@hgschmie hgschmie merged commit 9c0d940 into basepom:master Jul 6, 2017
hgschmie pushed a commit that referenced this pull request Jul 6, 2017
@jhaber
Copy link
Contributor Author

jhaber commented Jul 7, 2017

Thanks! Let me know if you find any issues with the plugin or want any features added

hgschmie pushed a commit to hgschmie/basepom that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants