Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[システム]BcValidation::checkDateの調査 #2189

Closed
seto1 opened this issue May 17, 2023 · 1 comment
Closed

[システム]BcValidation::checkDateの調査 #2189

seto1 opened this issue May 17, 2023 · 1 comment
Assignees
Labels
Adjusting 調整中

Comments

@seto1
Copy link
Collaborator

seto1 commented May 17, 2023

概要

#1930 (comment) から切り出し

BcValidation::checkDateとcakeのdateTimeバリデーションの役割の違いについて確認し、重複している場合はまとめる

baserCMS version : 5.0.1-dev

@ryuring ryuring added the ver5 label May 17, 2023
@ryuring ryuring removed the ver5 label Jun 6, 2023
@gondoh gondoh added the Adjusting 調整中 label Jun 22, 2023
fuchigam1 pushed a commit to fuchigam1/basercms that referenced this issue Jun 23, 2023
seto1 added a commit to seto1/basercms that referenced this issue Nov 24, 2023
seto1 added a commit to seto1/basercms that referenced this issue Nov 24, 2023
@seto1
Copy link
Collaborator Author

seto1 commented Nov 24, 2023

seto1@9184e92 にて対応中

cakeのdateTimeで代用可能なため、BcValidation::checkDateと使用箇所を削除
また、このルールへの対応のためだけに必要な日時の変換処理を削除

# 例
if (!empty($postData['posted'])) $postData['posted'] = new FrozenTime($postData['posted']);

以下課題の完了後に再度動作確認
#2881

seto1 added a commit to seto1/basercms that referenced this issue Nov 30, 2023
seto1 added a commit to seto1/basercms that referenced this issue Nov 30, 2023
@ryuring ryuring closed this as completed in fe66b59 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adjusting 調整中
Projects
None yet
Development

No branches or pull requests

3 participants