Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File / Folder を置き換える #2773

Closed
8 tasks
ryuring opened this issue Sep 28, 2023 · 2 comments
Closed
8 tasks

File / Folder を置き換える #2773

ryuring opened this issue Sep 28, 2023 · 2 comments
Assignees
@nghiem-mb
Labels
Todo 実行確定タスク
Milestone
5.1.0

Comments

@ryuring
Copy link
Collaborator

ryuring commented Sep 28, 2023 •
edited

概要

File / Folder について、CakePHP5で削除されるため、別の仕組みに置き換える

TODO

  • dev-#2773 ブランチをチェックアウト
  • PhpStormのコードインスペクションで plugins ディレクトリを指定して利用箇所を洗い出す
  • PHP → 一般 → 非推奨 で利用箇所を確認
  • BcFolder / BcFile を利用し非推奨を書き換える
  • BcFolder / BcFile に足りないメソッドがあれば実装しテストも書く
  • ユニットテストで問題がないか確認
  • ブラウザでのテストも実施する
  • dev-5 ではなっく、dev-#2773 ブランチにプルリクエストを送る（１ファイルずつお願いします）

参考情報

  • 対象箇所は300箇所弱
  • ユニットテストでの利用箇所から書き換える

コードインスペクションの画面

スクリーンショット 2023-10-01 16 42 35 スクリーンショット 2023-10-01 16 43 17

baserCMS version : 5.0.5
@ryuring ryuring added the Todo 実行確定タスク label Sep 28, 2023
@ryuring ryuring added this to the 5.1.0 milestone Sep 28, 2023
@ryuring ryuring self-assigned this Sep 28, 2023
ryuring added a commit to ryuring/basercms that referenced this issue Oct 1, 2023
@ryuring
Merge branch 'dev-5' into dev-baserproject#2773
a2b3126
@ryuring ryuring assigned nghiem-mb and unassigned ryuring Oct 1, 2023
@ryuring
Copy link
Collaborator Author

ryuring commented Oct 1, 2023

@nghiem-mb CakePHP5より、File / Folder クラスが削除となります。こちらについて、BcFile / BcFolder クラスに書き換えをお願いします。かなりの量があり、影響が大きいクラスですので、焦らず、注意深くお願いします。

nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 4, 2023
@nghiem-mb
Merge branch '2773-BcBaserHelperTest' into dev-baserproject#2773-BcDa…
4101c7c 
…tabaseServiceTest
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 6, 2023
@nghiem-mb
Merge branch '2773-BcBaserHelperTest' into dev-baserproject#2773-BcDa…
fbbfb91 
…tabaseServiceTest
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 9, 2023
@nghiem-mb
dev-baserproject#2773-BcPlugin
10f4fe7
ryuring pushed a commit that referenced this issue Oct 9, 2023
@nghiem-mb
Dev #2773 bc database service test (#2782)
dac78cd
ryuring added a commit that referenced this issue Oct 9, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
c800c80
ryuring added a commit that referenced this issue Oct 9, 2023
@ryuring
Merge branch 'dev-#2773' of github.com:baserproject/basercms into dev-#…
1ed9f35 
…2773
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 10, 2023
@nghiem-mb
Merge branch 'dev-5' into dev-baserproject#2773-BcPlugin
5003bb0 
# Conflicts:
#	plugins/baser-core/src/Utility/BcFolder.php
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 10, 2023
@nghiem-mb
Merge branch 'dev-baserproject#2773' into dev-baserproject#2773-BcPlugin
bbfad66
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 10, 2023
@nghiem-mb
Merge branch 'dev-5' into dev-baserproject#2773-BcPlugin
12233de 
# Conflicts:
#	plugins/bc-blog/src/Controller/BlogController.php
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 10, 2023
@nghiem-mb
Merge branch 'dev-baserproject#2773' into dev-baserproject#2773-BcPlugin
fd80d04 
# Conflicts:
#	plugins/bc-blog/src/Controller/BlogController.php
ryuring added a commit that referenced this issue Oct 16, 2023
@nghiem-mb @ryuring
Dev #2773 bc test case (#2799)
20ec115 
Co-authored-by: ryuring <egashira@catchup.co.jp>
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 16, 2023
@nghiem-mb
Merge remote-tracking branch 'origin/dev-#2773' into dev-baserproject…
94062ae 
…#2773
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 16, 2023
@nghiem-mb
Merge branch 'dev-baserproject#2773' into dev-baserproject#2773-BcPlugin
a21a386
ryuring added a commit that referenced this issue Oct 19, 2023
@nghiem-mb @ryuring
Dev #2773 bc plugin (#2797)
64e628a 
Co-authored-by: ryuring <egashira@catchup.co.jp>
ryuring added a commit that referenced this issue Oct 22, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
a79c928
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Oct 23, 2023
@nghiem-mb
Merge remote-tracking branch 'origin/dev-#2773' into dev-baserproject…
ce18283 
…#2773-BcUtil
ryuring added a commit that referenced this issue Oct 25, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
3d14799
ryuring pushed a commit that referenced this issue Oct 26, 2023
@nghiem-mb
Dev #2773 bc util (#2812)
2b34e4b
ryuring added a commit that referenced this issue Oct 27, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
6edd143
ryuring added a commit that referenced this issue Oct 27, 2023
@ryuring
Merge branch 'dev-#2773' of github.com:baserproject/basercms into dev-#…
34e6004 
…2773
ryuring added a commit that referenced this issue Oct 27, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
e90d4f6
ryuring added a commit that referenced this issue Oct 28, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
b4a8217
ryuring added a commit that referenced this issue Oct 28, 2023
@ryuring
Merge branch 'dev-#2773' into dev-cake45
f955e1e
ryuring pushed a commit that referenced this issue Nov 9, 2023
@nghiem-mb
Dev #2773 plugin test (#2846)
9f27b43 
* PluginTest

* PluginTest
ryuring added a commit to ryuring/basercms that referenced this issue Nov 16, 2023
@ryuring
Merge branch 'dev-5' into dev-baserproject#2773
53f09ee
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Nov 16, 2023
@nghiem-mb
Merge branch 'dev-5' into dev-baserproject#2773
e420577 
# Conflicts:
#	plugins/baser-core/src/Controller/AppController.php
#	plugins/baser-core/tests/TestCase/View/Helper/BcBaserHelperTest.php
#	plugins/bc-theme-file/src/Service/ThemeFilesService.php
#	plugins/bc-theme-file/tests/TestCase/Controller/Api/Admin/ThemeFilesControllerTest.php
#	plugins/bc-uploader/tests/TestCase/Controller/UploaderFilesControllerTest.php
#	plugins/bc-uploader/tests/TestCase/Service/UploadFilesServiceTest.php
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Nov 21, 2023
@nghiem-mb
Merge remote-tracking branch 'origin/dev-#2773' into dev-baserproject…
7c524f4 
…#2773
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Nov 21, 2023
@nghiem-mb
Merge branch 'dev-baserproject#2773' into dev-baserproject#2773-dev5-…
190c78e 
…merge
nghiem-mb added a commit to nghiem-mb/basercms that referenced this issue Nov 21, 2023
@nghiem-mb
Merge branch 'dev-5' into dev-baserproject#2773-dev5-merge
11fabd1
ryuring pushed a commit that referenced this issue Nov 24, 2023
@nghiem-mb
Dev #2773 dev5 merge (#2871)
15c3bf9
ryuring added a commit that referenced this issue Nov 24, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
619756c
ryuring added a commit that referenced this issue Nov 26, 2023
@ryuring
Merge branch 'dev-5' into dev-#2773
0e449d9
@ryuring
Copy link
Collaborator Author

ryuring commented Nov 26, 2023

dev-cake5 ブランチにて解決済
@nghiem-mb ありがとうございました！

@ryuring ryuring closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghiem-mb nghiem-mb

Labels
Todo 実行確定タスク
Projects
None yet
Milestone
5.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

dev-#2773 baserproject/basercms
2 participants
@ryuring @nghiem-mb