Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixtureManager を FixtureFactory に変更する #2883

Closed
ryuring opened this issue Nov 26, 2023 · 2 comments
Closed

FixtureManager を FixtureFactory に変更する #2883

ryuring opened this issue Nov 26, 2023 · 2 comments
Assignees
@HungDV2022 @nghiem-mb
Labels
Todo 実行確定タスク
Milestone
5.1.0

Comments

@ryuring
Copy link
Collaborator

ryuring commented Nov 26, 2023 •
edited

概要

CakePHP5にて、FixtureManager が除外されるため、ユニットテストで、FixtureManager を利用している箇所について、FixtureFactory に変更する。

dev-cake5 ブランチよりトピックブランチを作成し、dev-cake5 ブランチにプルリクエストを送信する。

baserCMS version : 5.0.6
@ryuring ryuring added the Todo 実行確定タスク label Nov 26, 2023
@ryuring ryuring added this to the 5.1.0 milestone Nov 26, 2023
@ryuring ryuring changed the title FixtureManager を除外する FixtureManager を FixtureFactory に変更する Nov 26, 2023
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Nov 29, 2023
@dovanhung
bc-widget-area FixtureManager を FixtureFactory に変更する baserproject#2883
b1392f0
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Nov 29, 2023
@dovanhung
bc-theme-config FixtureManager を FixtureFactory に変更する baserproject#2883
88cc880
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Nov 29, 2023
@dovanhung
BcSearchIndex FixtureManager を FixtureFactory に変更する baserproject#2883
30b56f3
ryuring pushed a commit that referenced this issue Nov 29, 2023
@HungDV2022 @dovanhung
bc-widget-area FixtureManager を FixtureFactory に変更する #2883 (#2891)
d37ee83 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Nov 29, 2023
@HungDV2022 @dovanhung
bc-theme-config FixtureManager を FixtureFactory に変更する #2883 (#2892)
233f4a9 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Nov 29, 2023
@HungDV2022 @dovanhung
BcSearchIndex FixtureManager を FixtureFactory に変更する #2883 (#2893)
896a2c1 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Nov 29, 2023
@dovanhung
BcMail FixtureManager を FixtureFactory に変更する baserproject#2883
5ae31a9
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Nov 29, 2023
@dovanhung
BcEditorTemplate FixtureManager を FixtureFactory に変更する baserproject#2883
8a99470
@nghiem-mb nghiem-mb mentioned this issue Nov 30, 2023
Closed
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 1, 2023
@dovanhung
BcBlog FixtureManager を FixtureFactory に変更する baserproject#2883
9b7a8b4
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 1, 2023
@dovanhung
BcBlog FixtureManager を FixtureFactory に変更する baserproject#2883
523cb2f
ryuring pushed a commit that referenced this issue Dec 1, 2023
@HungDV2022 @dovanhung
BcMail FixtureManager を FixtureFactory に変更する #2883 (#2897)
c8f55bc 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 1, 2023
@HungDV2022 @dovanhung
BcEditorTemplate FixtureManager を FixtureFactory に変更する #2883 (#2898)
19c047e 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 1, 2023
@HungDV2022 @dovanhung
BcBlog FixtureManager を FixtureFactory に変更する #2883 (#2909)
37dc945 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 1, 2023
@dovanhung
BcCore/Event FixtureManager を FixtureFactory に変更する baserproject#2883
c04b431
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 1, 2023
@dovanhung
BcCore/Middleware FixtureManager を FixtureFactory に変更する baserproject#…
c6c01de 
…2883
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 4, 2023
@dovanhung
BcCore/Middleware FixtureManager を FixtureFactory に変更する baserproject#…
cb184f4 
…2883
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 4, 2023
@dovanhung
BcCore/Middleware FixtureManager を FixtureFactory に変更する baserproject#…
ac99f02 
…2883
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 4, 2023
@dovanhung
BcCore/Modal FixtureManager を FixtureFactory に変更する baserproject#2883
3f8a281
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 4, 2023
@dovanhung
BcCore/Modal FixtureManager を FixtureFactory に変更する baserproject#2883
9f15aad
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 4, 2023
@dovanhung
BcCore/Routing FixtureManager を FixtureFactory に変更する baserproject#2883
291ff23
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
ba912a5
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
6847be7
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
95a2adf
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
277eccb
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/TestSuite FixtureManager を FixtureFactory に変更する baserproject#2883
5f0151b
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/Utility FixtureManager を FixtureFactory に変更する baserproject#2883
2e710a7
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 6, 2023
@dovanhung
BcCore/TestSuite FixtureManager を FixtureFactory に変更する baserproject#2883
7fa5e43
ryuring pushed a commit that referenced this issue Dec 7, 2023
@HungDV2022 @dovanhung
BcCore/Routing FixtureManager を FixtureFactory に変更する #2883 (#2919)
735ff92 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 7, 2023
@dovanhung
BcCore/TestSuite FixtureManager を FixtureFactory に変更する baserproject#2883
f969d39
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 7, 2023
@dovanhung
BcCore/TestSuite FixtureManager を FixtureFactory に変更する baserproject#2883
a4b07c8
ryuring pushed a commit that referenced this issue Dec 7, 2023
@HungDV2022 @dovanhung
BcCore/TestSuite FixtureManager を FixtureFactory に変更する #2883 (#2922)
857b7a6 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 7, 2023
@HungDV2022 @dovanhung
BcCore/Utility FixtureManager を FixtureFactory に変更する #2883 (#2923)
1fa555e 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 7, 2023
@HungDV2022 @dovanhung
BcCore/Middleware FixtureManager を FixtureFactory に変更する #2883 (#2914)
1bbfd25 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 7, 2023
@HungDV2022 @dovanhung
BcCore/Event FixtureManager を FixtureFactory に変更する #2883 (#2913)
21a75a1 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 8, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
75ff0d3
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 8, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
328a9fc
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 8, 2023
@dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する baserproject#2883
6cc991a
ryuring pushed a commit that referenced this issue Dec 8, 2023
@HungDV2022 @dovanhung
BcCore/Modal FixtureManager を FixtureFactory に変更する #2883 (#2918)
e070a7b 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
ryuring pushed a commit that referenced this issue Dec 8, 2023
@HungDV2022 @dovanhung
BcCore/Service FixtureManager を FixtureFactory に変更する #2883 (#2921)
f27598a 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 14, 2023
@dovanhung
fix baserproject#2883 BcCore/View FixtureManager を FixtureFactory に変更する
e5533fb
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 14, 2023
@dovanhung
fix baserproject#2883 BcCore/View FixtureManager を FixtureFactory に変更する
b8a36dc
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 14, 2023
@dovanhung
fix baserproject#2883 BcCore/View FixtureManager を FixtureFactory に変更する
6cf0f47
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 14, 2023
@dovanhung
fix baserproject#2883 BcCore/View FixtureManager を FixtureFactory に変更する
7eaaf08
HungDV2022 pushed a commit to HungDV2022/basercms that referenced this issue Dec 14, 2023
@dovanhung
fix baserproject#2883 BcCore/View FixtureManager を FixtureFactory に変更する
0dcf3d8
ryuring pushed a commit that referenced this issue Dec 15, 2023
@HungDV2022 @dovanhung
fix #2883 BcCore/View FixtureManager を FixtureFactory に変更する (#2941)
3e1d9f7 
Co-authored-by: Đỗ Văn Hùng <dovanhungk57@gmail.com>
@HungDV2022
Copy link
Collaborator

@ryuring こちらは対応しましたのでクローズします。

@ryuring
Copy link
Collaborator Author

ryuring commented Feb 15, 2024

@HungDV2022 大変でしたね、ありがとうございました！！！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HungDV2022 HungDV2022

@nghiem-mb nghiem-mb

Labels
Todo 実行確定タスク
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
3 participants
@ryuring @HungDV2022 @nghiem-mb