Fix #1203 : BcBaserHelper::getDescription() がトップページでサイト基本説明文を取得できない問題を修正 #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…説明文を取得できない問題を修正
tnagatomi
changed the title
tnagatomi
changed the title
|
テストが失敗しているようなので調整します。 |
|
@tommy6073 テストは別の問題で失敗していると思います。マージしました。 |
|
@tommy6073 いや、このコミットでの失敗ですね。調整お願いします。 |
tnagatomi
added a commit
to tnagatomi/basercms
that referenced
this pull request
Jul 2, 2019
tnagatomi
added a commit
to tnagatomi/basercms
that referenced
this pull request
Jul 2, 2019
tnagatomi
added a commit
to tnagatomi/basercms
that referenced
this pull request
Jul 2, 2019
Merged
ryuring
pushed a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1203
BcBaserHelper::getDescription() がトップページでサイト基本説明文を取得できない問題を修正しました。
$this->request->params['Content']['site_root']ではなくisHome()を利用してトップページかどうか判定するように変更しました。ご確認よろしくお願いします。