fix #1529 管理画面ログイン、ログアウト時の処理を拡張する為のイベントを追加 #1541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaburk ありがとうございます。 プルリクの仕様は次となっているようです
|
|
@kaburk 実際の実務などでイベントの実装要件があったのかと思いますが、どういった要求しようでしたか？？ |
|
イベントの実装として、基本的に、before の処理では、本体に影響を与えることができて、after では影響はない処理にすると仕様がスッキリするかと思います。 |
|
@kaburk こちら次のバージョンで取り込みましょう。 |
ryuring
reviewed
Nov 10, 2020
|
|
||
| // EVENT Users.beforeLogin | ||
| $event = $this->dispatchEvent('beforeLogin', [ | ||
| 'data' => $this->request->data |
|
|
||
| // EVENT Users.afterLogin | ||
| $this->dispatchEvent('afterLogin', [ | ||
| 'data' => $this->request->data, |
| @@ -170,6 +185,12 @@ public function admin_ajax_agent_login($id) { | |||
| $this->Session->write('AuthAgent', $user); | |||
| } | |||
|
|
|||
| // EVENT Users.beforeAgentLogin | |||
| $event = $this->dispatchEvent('beforeAgentLogin', [ | |||
| 'data' => $id, | |||
There was a problem hiding this comment.
beforeUser 、afterUser を引き渡して、代理ログインユーザーを afterUser で書き換える
| @@ -179,6 +200,13 @@ public function admin_ajax_agent_login($id) { | |||
| if ($user) { | |||
| $this->Session->renew(); | |||
| $this->Session->write(BcAuthComponent::$sessionKey, $user); | |||
|
|
|||
| // EVENT Users.afterAgentLogin | |||
| $this->dispatchEvent('afterAgentLogin', [ | |||
There was a problem hiding this comment.
beforeUser 、afterUser を引き渡す
|
|
||
| // EVENT Users.beforeBackAgent | ||
| $event = $this->dispatchEvent('beforeBackAgent', [ | ||
| 'data' => $data, |
There was a problem hiding this comment.
beforeUser 、afterUser を引き渡して、元ログインユーザーを afterUser で書き換える
|
|
||
| // EVENT Users.afterBackAgent | ||
| $event = $this->dispatchEvent('afterBackAgent', [ | ||
| 'data' => $authPrefix, |
|
|
||
| // EVENT Users.beforeLogout | ||
| $event = $this->dispatchEvent('beforeLogout', [ | ||
| 'data' => $this->BcAuth->user(), |
|
|
||
| // EVENT Users.afterLogout | ||
| $event = $this->dispatchEvent('afterLogout', [ | ||
| 'data' => $logoutRedirect, |
|
@kaburk レビューが中途半端になってて送信できてなかったので送りました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues #1529 の件の管理画面ログイン、ログアウト前後のイベントを追加してみました。
よろしくお願いいたします。