Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

「メールコンテンツの編集前・編集後」のイベントを追加 #2055

Merged
merged 2 commits into from Apr 19, 2023
Merged

「メールコンテンツの編集前・編集後」のイベントを追加 #2055

merged 2 commits into from Apr 19, 2023

Conversation

HungDV2022
Copy link
Collaborator

No description provided.

@HungDV2022 HungDV2022 assigned nghiem-mb and ryuring and unassigned nghiem-mb Apr 18, 2023
@ryuring
Copy link
Collaborator

ryuring commented Apr 18, 2023

@HungDV2022 先ほどこちらにも書きましたが、Factoryのコードはできるだけ短くなるよう「工夫」をお願いします。
#2054 (comment)

@ryuring ryuring assigned HungDV2022 and unassigned ryuring Apr 18, 2023
@ryuring ryuring added the Reviewed レビュー済 label Apr 18, 2023
@HungDV2022
Copy link
Collaborator Author

@ryuring
こちらを修正しました。確認お願いします。

@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Apr 18, 2023
@ryuring ryuring merged commit f2859f6 into baserproject:dev-5 Apr 19, 2023
1 check passed
kaburk pushed a commit to kaburk/basercms that referenced this pull request Apr 19, 2023
@HungDV2022 @t-uchiba @ryuring
fix baserproject#2048 API アクセスグループ 一覧取得 (baserproject#2055)
f7a740a 
Co-authored-by: Đỗ Văn Hùng <HungDV2022>
Co-authored-by: Tatsuhiko Uchiba <37653901+t-uchiba@users.noreply.github.com>
Co-authored-by: ryuring <egashira@catchup.co.jp>
@gondoh gondoh added this to the 5.0.1 milestone Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryuring ryuring

Labels
Reviewed レビュー済
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HungDV2022 @ryuring @gondoh @nghiem-mb