Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BlogCommentsService::getNew #3133

Merged

Conversation

thangnnmd
Copy link
Collaborator

add unitest BlogCommentsService::getNew

@HungDV2022
Copy link
Collaborator

@ryuring レピューをお願いします。

@ryuring
Copy link
Collaborator

ryuring commented Feb 19, 2024

@HungDV2022 @thangnnmd ありがとうございます。内容はOKですがコンフリクトしましたので調整お願いします。

@ryuring ryuring assigned HungDV2022 and thangnnmd and unassigned ryuring Feb 19, 2024
@ryuring ryuring added the Reviewed レビュー済 label Feb 19, 2024
@thangnnmd
Copy link
Collaborator Author

@HungDV2022 fixed conflict

@thangnnmd thangnnmd removed their assignment Feb 20, 2024
@HungDV2022 HungDV2022 assigned ryuring and unassigned HungDV2022 Feb 20, 2024
@ryuring
Copy link
Collaborator

ryuring commented Feb 21, 2024

@thangnnmd thank you!

@ryuring ryuring merged commit e945880 into baserproject:dev-5.1 Feb 21, 2024
1 check passed
@ryuring ryuring added this to the 5.1.0 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed レビュー済
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants