Filter out healthcheck endpoints from access logging #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrochette
reviewed
Feb 7, 2023
pankajroark
reviewed
Feb 7, 2023
| # for any health check endpoints, lets skip logging | ||
| return ( | ||
| record.getMessage().find("/") == -1 | ||
| and record.getMessage().find("/v1/models/model") == -1 |
There was a problem hiding this comment.
It would be good to move the healthcheck endpoints to constants somewhere. I feel this /v1/models/model is too verbose and we may want to change this in future, so would be good to have it consolidated as constant.
pankajroark
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
I think @jrochette 's comment is worth double checking on. Otherwise, lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We don't want to display access logging by default for healthcheck endpoints
How
Adding a logging filter for the
uvicorn.accesslogger to filter out by endpoint