Make Docker images smaller by deleting pip cache #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajroark
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Lgtm. Worth trying out the python requirement install flow for the live reloadable image, to see if removing pip cache has an adverse impact on that. It probably won't have a huge impact, so I'm reluctant to suggest optimizing that case.
Would be also good to know how much space this saves on the base images.
|
This save 2GB for uncompressed disc for dreambooth training. I think it's worth merging: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.