Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python version in GPU base images #235

Merged

Conversation

bolasim
Copy link
Collaborator

@bolasim bolasim commented Feb 24, 2023

Base GPU Image should match the python version in the config to be consistent. Once this is merged, we can re-run the base image build and push workflow.

Copy link
Collaborator

@pankajroark pankajroark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test the GPU models with 3.8. Otherwise lgtm.

@bolasim
Copy link
Collaborator Author

bolasim commented Feb 28, 2023

What is the best way to test that? I was just gonna generate the docker images and shell in to make sure python is 3.8 and the gpu utils (like nvidia-smi) are installed

@bolasim bolasim merged commit 0ebf701 into main Mar 8, 2023
@bolasim bolasim deleted the 234-base-image-does-not-respect-python-version-from-truss branch March 8, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base image does not respect python version from truss
2 participants