Reverted https://github.com/basetenlabs/truss/pull/231 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squidarth
changed the title
squidarth
changed the title
bolasim
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
cc: @pankajroark reverting because this breaks for git+https:// requirement links
|
hi @tugrulguner ! Unfortunately, we had to revert this commit because it didn't acount for 'git+https://` style git requirements and caused a failure downstream. If you'd like, feel free to add it back with some more tests to take care of that case. If not, don't worry about it. We're happy to do it too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a bug where "git" python requirements are not parsed correctly, so reverting this change for now. Will revert back later w/ a fix for the issue with git requirements