Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom base image support #268

Merged
merged 5 commits into from
Apr 24, 2023
Merged

custom base image support #268

merged 5 commits into from
Apr 24, 2023

Conversation

joostinyi
Copy link
Collaborator

@joostinyi joostinyi commented Apr 19, 2023 •
edited

  • Adds a new top level config base_image wherein a user can supply a base image for base.Dockerfile
  • Implements fail fast mechanisms checking for the os and the python version
  • Introduces cache argument to the image builder to invalidate cache of RUN instructions across subsequent builds. See end of section

pankajroark
pankajroark approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@pankajroark pankajroark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

bolasim
bolasim approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just a few suggestions for code maintainability.

It would also be great to add an example AITemplate truss to the examples/ directory that uses this feature.

truss/contexts/image_builder/image_builder.py Show resolved Hide resolved
truss/templates/base.Dockerfile.jinja Outdated Show resolved Hide resolved
truss/templates/base.Dockerfile.jinja Outdated Show resolved Hide resolved
truss/tests/test_truss_handle.py Show resolved Hide resolved
@joostinyi
Copy link
Collaborator Author

@bolasim looked into adding an AITemplate example and it is quite involved – will tackle in a follow up

@joostinyi joostinyi merged commit 6c86043 into main Apr 24, 2023
3 checks passed
@joostinyi joostinyi deleted the justin/custom-base-image-support branch April 24, 2023 18:10
pankajroark added a commit that referenced this pull request Apr 26, 2023
@pankajroark
Revert "custom base image support (#268)"
85ae154 
This reverts commit 6c86043.
pankajroark added a commit that referenced this pull request Apr 26, 2023
@pankajroark
Revert "custom base image support (#268)" (#272)
c6d9990
@joostinyi joostinyi mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajroark pankajroark pankajroark approved these changes

@bolasim bolasim bolasim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joostinyi @pankajroark @bolasim