"control_server_host" now binds to both IPV4 & IPV6 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay here, I want to run some integrations test on this before approving. I will do that soon. |
|
I mirrored the branch on Will update with results when they are done. |
|
@pankajroark looks like the integration tests passed: https://github.com/basetenlabs/truss/actions/runs/5004121292/jobs/8966282756 I'll leave it up to you to see if there is anything else that we should check here |
pankajroark
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
control_server_hostis currently set to0.0.0.0which forces waitress to only bind to the IPV4 address. According to the waitress docs by changing from0.0.0.0to*will cause it to bind to both.