-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for patching #296
Conversation
Would be great to have at least some unit tests for the patches. |
@ujjwal @pankajroark I addressed all comments with the exception of the unit tests for the specific patches. Don't want to get blocked on that for rolling this out. Let's do that in a followup. Let me know if there is anything else that needs to get addressed here before rollout |
546944b
to
7c9fdf3
Compare
logger.info(f"{patch_name} patch applied successfully") | ||
except Exception as e: | ||
logger.debug( | ||
f"{patch_name} patch could not be applied. Exception: {str(e)}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should double check that these logs don't show up. I think it will be common that not all patches would apply for a model.
Overview
This PR adds support to Truss to apply monkeypatches to various libs. It also adds a new field in the config
enable_patches
(defaults to True) which enables/disables this behavior.This PR also includes 2 patches:
b10cp
compatibleTesting
I tested the following flows
To test the docker flow, following the steps below:
bin/generate_base_images.py
. To conserve space on your device (this script can create many images at once), you can run the following command to produce a non-GPU, non-live reload, serving image: