Update base-images.md #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipkiely-baseten
requested changes
Jun 5, 2023
philipkiely-baseten
force-pushed
the
pankajroark-patch-1
branch
from
cb644eb
to
5e8629d
Compare
philipkiely-baseten
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
@pankajroark I tried my best to clarify and shorten the docs. Please let me know if I left out any key details.
I also re-organized this as a "contributor" doc because it only seems relevant to people contributing to Truss, not everyday users. If that's incorrect, I'll put it back with the main docs.
|
@pankajroark is this good to merge? |
|
@philipkiely-baseten this looks good. Can you just resolve the conflicts and we'll merge it? |
philipkiely-baseten
force-pushed
the
pankajroark-patch-1
branch
from
4277b25
to
3e0f97f
Compare
|
Cool, rebased and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.