Rework deployment workflow to build baseimage based on version changes #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion, I have updated the Github action to detect if the
TRUSS_BASE_IMAGE_VERSION_TAGchanges.If it does, then we build all the bae images that are needed before running the integration tests using that tag (it doesn't make sense to build based on the pyproject.toml version since it won't be picked up if it does not match
TRUSS_BASE_IMAGE_VERSION_TAG).This effectively makes
TRUSS_BASE_IMAGE_VERSION_TAGa separate version for Base Images that managed separately