Modify custom base image venv patch #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests passed here: https://github.com/basetenlabs/truss/actions/runs/5195534750/jobs/9368353618 |
bolasim
changed the title
joostinyi
changed the title
bolasim
commented
Jun 7, 2023
joostinyi
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests are failing because it's not possible to apply the venv patch to our base images.
I think that's okay for now. Just going to drop this to unblock the release and we can revisit this edge case as needed for specific custom base images (most of them will have venv anyways so it's okay).
Edit: Attempt to apply venv patch if venv is not installed on the python package present